Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.7.8.8 #28522

Closed
6 tasks done
matks opened this issue May 18, 2022 · 47 comments
Closed
6 tasks done

Release 1.7.8.8 #28522

matks opened this issue May 18, 2022 · 47 comments
Assignees
Labels
Release Status for a given release Topwatchers Backlog prioritization: issue reported & followed by +6 people

Comments

@matks
Copy link
Contributor

matks commented May 18, 2022

This issue tracks the status of the PrestaShop 1.7.8.8 release

Information

Q A
Type Patch version
Build date 2022-11-25
Milestone 1.7.8.8
Kanban 1.7.8.8
Delivery date 2022-12-08
Release manager tech @mflasquin
Release manager product @eshraw
Release manager QA @HanaRebaiQA

Current status

  • Development
  • Build
  • QA validation
  • Release
  • Available for upgrade
  • Docker image
@matks matks added Bug Type: Bug New New issue not yet processed by QA Release Status for a given release labels May 18, 2022
@matks matks pinned this issue May 18, 2022
@matks matks removed Bug Type: Bug New New issue not yet processed by QA labels May 18, 2022
@Murat-06

This comment was marked as off-topic.

@matks
Copy link
Contributor Author

matks commented Jun 28, 2022

@Murat-06 You need to open a feature request in order for your ideas to be analyzed -> https://github.com/PrestaShop/PrestaShop/issues/new?assignees=&labels=Bug%2CNew&template=1_bug_report.yml

@matks
Copy link
Contributor Author

matks commented Jun 28, 2022

Date update

As we focus on 8.0.0 for now, expected release date has been set for 18th of July

@matks
Copy link
Contributor Author

matks commented Jul 18, 2022

Date update

The QA team focus is autoupgrade module, it is needed to explore whether upgrade from 1.7.x versions to 8.0.0 are OK and register known issues.

Following this exploration 1.7.8.7 build, test and release will be possible.

@letwang
Copy link

letwang commented Jul 21, 2022

Is this going to be delayed?

@matks
Copy link
Contributor Author

matks commented Jul 21, 2022

@letwang Yes, as mentioned above we are right now focusing on the autoupgrade testing campaign for 8.0.0 and it requires most of the QA team capacity so it we cannot test the 1.7.8.7 at the same time

@letwang
Copy link

letwang commented Jul 22, 2022

Author

The implication is that the current latest stable version 1.7.8.6 will exist for a long time?

@matks
Copy link
Contributor Author

matks commented Jul 22, 2022

It depends what you call a long time. I think 1.7.8.7 will be delivered somewhere in August or September, so 2 months. It's just a guess though.

@matks matks changed the title Release 1.7.8.7 Release 1.7.8.8 Jul 24, 2022
@matks
Copy link
Contributor Author

matks commented Jul 24, 2022

Scope and version update

Following the discovery of a major security vulnerability, the version 1.7.8.7 will be a security patch release targeting the attack.

This version, initially planned to be 1.7.8.7, will become 1.7.8.8 .

@letwang
Copy link

letwang commented Jul 25, 2022

Good Job~

@vavrecan
Copy link

vavrecan commented Jul 25, 2022

how does update to (SmartyCacheResourceMysql.php)
$content = $this->phpEncryption->decrypt($row['content']);
from
$content = $row['content'];

and
"' . $this->phpEncryption->encrypt($content) . '"
from
"' . pSQL($content, true) . '"

will fix this security vulnerability? is latest update a joke?

@kpodemski
Copy link
Contributor

Could you elaborate @vavrecan?

@vavrecan
Copy link

can you explain how just changing way how the data is written in SQL query will affect the exploitation? does it mean there is security issue of how pSQL is escaping queries?

@vavrecan
Copy link

We compared 1.7.8.7 and 1.7.8.6 releases - and only relevant differences for major security vulnerability was just this change in SmartyCacheResourceMysql.php. It does not look right

@kpodemski
Copy link
Contributor

This fixes an attack where there's no access to files from the core and encryption keys. The data from the cache table is now secured, if you try to inject something there without knowing the encryption key, it will fail.

@vavrecan
Copy link

is it safe to trust output of $this->phpEncryption->encrypt?
If attack allowed to write custom content to smarty_cache, it would still go thought the encryption, or was there another point of how data were stored to ps_smarty_cache table?

@vavrecan
Copy link

i am just having a hard time to understanding the vulnerability - i though smarty_cache table is only accessed from SmartyCacheResourceMysql.php file

@ghost
Copy link

ghost commented Jul 25, 2022

The other way is with a SQL injection.
Now if you modify the content with a SQL injection the decryption don't wortk

@kpodemski
Copy link
Contributor

Most important thing you need to know: It is a valid fix for a vulnerability that the team found :)

@prestashop-issue-bot prestashop-issue-bot bot added the Topwatchers Backlog prioritization: issue reported & followed by +6 people label Jul 26, 2022
@kpodemski
Copy link
Contributor

@ismartfridge are you using MySQL cache for Smarty? You can check that in the Preferences -> Performance tab

@ismartfridge
Copy link

I use file system cache type since always.

@letwang
Copy link

letwang commented Jul 27, 2022

The 1.7.8.7 has some serious performance issue, updated from 1.7.8.5 and site loads even 10 seconds. I reverted to 1.7.8.5 and issue is gone.

image

image

Search api-addons.prestashop.com and api.addons.prestashop.com all over the site, but we’ve already found it for you, 3 places in total.

  • 1./app/config/config.yml (api-addons.prestashop.com)
  • 2./classes/Tools.php (api.addons.prestashop.com)
  • 3./controllers/admin/AdminSearchController.php (api-addons.prestashop.com)

Replace all the above URLs with local(127.0.0.1) virtual addresses.

image

Here, if necessary, it is best to clear the cache file again.

sudo rm -rf /var/cache/

@maofree
Copy link

maofree commented Aug 14, 2022

Hi @letwang
made correction in the 3 suggested files, I confirm they seem correct as corrections, the site seems to me more responsive

@matks
can you add these fix to the next version? however, I believe that there are no warnings of new versions of modules and the like. If anything, it would be useful to check that it is less invasive
thanks

@mrabsinthe
Copy link

What are the current plans for this version release? Still keeping the 6 weeks release cycle?

@matks
Copy link
Contributor Author

matks commented Sep 1, 2022

What are the current plans for this version release? Still keeping the 6 weeks release cycle?

As mentioned here priority is given to PrestaShop 8.0.0 for now. The project team does not have the capability to test both 8.0.0 and 1.7.8.8 so 1.7.8.8 is being delayed until the workload goes down.

We hope to be able to build, test and deliver 1.7.8.8 in September but this will happen only if all goes right with 8.0.0 . Unexpected issues found while testing 8.0.0 could delay this further.

The 6 weeks release cycle is consequently not applicable to PrestaShop 1.7.8.8

@matks
Copy link
Contributor Author

matks commented Sep 1, 2022

Just found this article I wrote 2 years ago
https://build.prestashop.com/news/ps17-patch-release-lifecycle/

If you read the section Why six weeks, and not eight or two ? you'll find what it is so expensive to build, test and deliver 1.7.8.8 and why we cannot do it at the same time as 8.0.0

@mrabsinthe
Copy link

Thank you for the clarification.

@kpodemski kpodemski removed the Topwatchers Backlog prioritization: issue reported & followed by +6 people label Sep 6, 2022
@prestashop-issue-bot prestashop-issue-bot bot added the Topwatchers Backlog prioritization: issue reported & followed by +6 people label Sep 17, 2022
@matks
Copy link
Contributor Author

matks commented Sep 23, 2022

It depends what you call a long time. I think 1.7.8.7 will be delivered somewhere in August or September, so 2 months. It's just a guess though.

Status update

PrestaShop 8.0.0 delivering and testing is taking longer than expected so PrestaShop 1.7.8.8 can be expected to be delivered in October.

@Progi1984 Progi1984 assigned HanaRebaiQA and unassigned florine2623 Nov 4, 2022
@molsondry
Copy link

It's been for 10 months now since I discovered a major core error which was reported 6 months ago (#28688), which seems to be fit now, but the release isn't available even now. Really a mess. My shop doesn't work and I have got a lot of worries with my customers since variation handling in combination with individualization produces lots of errors.
I'm considering swapping to another shopware, thinking shopify has got shorter update cycles.

@kpodemski
Copy link
Contributor

Hello @molsondry

PrestaShop is an open source, community project. If you find that any issue is critical for you, and it's important to have it fixed ASAP, then you can invest into having it done. You can hire a developer to fix it, or if you are a developer yourself, you can try doing it on your own. The most important thing is to share that fix with everyone by submitting a Pull Request -- that's what the open source spirit is all about.

@letwang
Copy link

letwang commented Nov 7, 2022

It's been for 10 months now since I discovered a major core error which was reported 6 months ago (#28688), which seems to be fit now, but the release isn't available even now. Really a mess. My shop doesn't work and I have got a lot of worries with my customers since variation handling in combination with individualization produces lots of errors. I'm considering swapping to another shopware, thinking shopify has got shorter update cycles.

I'm a developer and you can pay me to solve problems in the future.

@matks matks assigned mflasquin and unassigned matthieu-rolland Nov 22, 2022
@matks
Copy link
Contributor Author

matks commented Nov 23, 2022

2022-11-23 Status update

Scope of 1.7.8.8 should not change anymore, we're going to build a 1.7.8.8 ZIP soon (this week or next week) and deliver it to QA team for testing

@letwang
Copy link

letwang commented Nov 24, 2022

When will the patch version 8.0 be released?

@mflasquin
Copy link
Contributor

mflasquin commented Nov 25, 2022

2022-11-25 Status update

Hi, the build has been delivered to QA team

@HartLarsson
Copy link

HartLarsson commented Nov 26, 2022

The 1.7.8.7 has some serious performance issue, updated from 1.7.8.5 and site loads even 10 seconds. I reverted to 1.7.8.5 and issue is gone.

image

image

Search api-addons.prestashop.com and api.addons.prestashop.com all over the site, but we’ve already found it for you, 3 places in total.

  • 1./app/config/config.yml (api-addons.prestashop.com)
  • 2./classes/Tools.php (api.addons.prestashop.com)
  • 3./controllers/admin/AdminSearchController.php (api-addons.prestashop.com)

Replace all the above URLs with local(127.0.0.1) virtual addresses.

image

Here, if necessary, it is best to clear the cache file again.

sudo rm -rf /var/cache/

These fix for performance will hit in some way the addons functionalities?
thanks

@simbus82
Copy link

The 1.7.8.7 has some serious performance issue, updated from 1.7.8.5 and site loads even 10 seconds. I reverted to 1.7.8.5 and issue is gone.
These fix for performance will hit in some way the addons functionalities? thanks

Probably the modules update tab stops to work.

@HanaRebaiQA
Copy link

HanaRebaiQA commented Nov 30, 2022

Hello everyone,

Final report of QA Team of the 1.7.8.8 build1 :

  • The functional test campaign is done: OK
  • The exploratory test campaign is done: OK

Summary of the issues detected during the test:

Minor :
#30438
#30431
#30446
#30430
#30422

Trivial :
#30424
#30423

Feature :
#30425

It's a GO for the release!
A big Thanks for all those who contributed from near or far for this release!

@Fera
Copy link

Fera commented Dec 8, 2022

Will we have to wait until 1.7.8.9 to fix bug #30478?

@mflasquin
Copy link
Contributor

🚀 ✅ STATUS UPDATE

1.7.8.8 is released !

@matks
Copy link
Contributor Author

matks commented Dec 8, 2022

Will we have to wait until 1.7.8.9 to fix bug #30478?

@Fera No 1.7.8.9 is planned. 1.7.8.8 will be the last regular 1.7.8.x patch version, as the branch now enters security-only maintenance phase. Next regular patches will now target 8.0.x branch.

If you find that #30478 is critical for you, and it's important to have it fixed ASAP, then you can invest into having it done. Do not wait for someone else to fix it. You can hire a developer to fix it, or if you are a developer yourself, you can try doing it on your own. The most important thing is to share that fix with everyone by submitting a Pull Request -- that's what the open source spirit is all about.

@matks matks unpinned this issue Dec 9, 2022
@matks matks closed this as completed Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Status for a given release Topwatchers Backlog prioritization: issue reported & followed by +6 people
Projects
None yet
Development

No branches or pull requests