Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading a crx file fails with CRX_REQUIRED_PROOF_MISSING on v1.40 #23680

Closed
pitsi opened this issue Jun 24, 2022 · 17 comments
Closed

Downloading a crx file fails with CRX_REQUIRED_PROOF_MISSING on v1.40 #23680

pitsi opened this issue Jun 24, 2022 · 17 comments
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix closed/wontfix feature/extensions OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. workaround-available

Comments

@pitsi
Copy link

pitsi commented Jun 24, 2022

Description

There are a couple of extensions that I use and are not in the chrome store, for unknown reasons. So, I download them and I install them manually with the procedure described below. But on v1.40, brave fails to even start the download and pops the error described in the title.

Steps to Reproduce

  1. Find an extension that is packed as a crx file, e.g. the one for libredirect
  2. Make sure "Ask where to save each file before downloading" (under brave://settings/downloads) is disabled.
  3. Try downloading by clicking on it and notice the message on the screenshot below. Downloading it via right click > "save link as" will not produce the same behavior.

Actual result:

This error comes up and the file is either not downloaded at all or deleted instantly after download. Downloading it from firefox or with wget has no issues.

2022-06-24-202210_1280x1024_scrot

Expected result:

The file should download with no issues and I would install it manually (= go to brave://extensions > enable developer mode > drag n drop the file in the extensions window).

Reproduces how often:

Easily.

Brave version (brave://version info)

Brave	1.40.105 Chromium: 103.0.5060.53 (Official Build) (64-bit) 
Revision	a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS	Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Probably
  • Can you reproduce this issue with the nightly channel? Probably

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? Yes

Miscellaneous Information:

There is another similar issue (#5524) from ~3 years ago, but that one has to do with installing while this one has to do with downloading.
The fact that it also happens on chromium 103 makes me believe that some built in security policy is blocking it. It did not happen on chromium 102 or brave 1.39 (or any other previous version).

@rebron rebron added feature/extensions priority/P4 Planned work. We expect to get to it "soon". labels Jun 24, 2022
@rebron rebron added this to Untriaged Backlog in General Jun 27, 2022
@fmarier
Copy link
Member

fmarier commented Jul 5, 2022

I did the following on Ubuntu 20.04 (X11 with i3) and it worked fine for me:

  1. Download the CRX file on https://github.com/libredirect/libredirect/releases/tag/v2.2.1.
  2. In a fresh Brave release profile, go to brave://extensions.
  3. Turn on developer mode.
  4. Drag and drop the downloaded CRX file from my download folder in Nautilus.
    Screenshot from 2022-07-05 16-03-11
    Screenshot from 2022-07-05 16-03-55
    Screenshot from 2022-07-05 16-04-03

Are you using Nautilus? Maybe it has something to do with the source of the drag n' drop.

@pitsi
Copy link
Author

pitsi commented Jul 6, 2022

Steps 2 to 5 are irrelevant to the behavior I describe, because the issue happens on step 1 only.
So, about that step. Did you right click > save as or did you just click the file and let the browser do the download? The first, as I just checked, will download the file, but the second one brings the forementioned behavior.

I use pcmanfm (the gtk version) as my file manager, but that is irrelevant.

@fmarier
Copy link
Member

fmarier commented Jul 6, 2022

Did you right click > save as or did you just click the file and let the browser do the download?

I just clicked the link and the save as dialog popped up automatically.

@pitsi
Copy link
Author

pitsi commented Jul 6, 2022

Is there a "save as" dialog in chromium based browsers? Maybe you have enabled the "ask where to save files when downloading" in brave://settings/downloads.

---edit
Just checked. Enabling the forementioned option allows the user to download the file as usual. That is practically the same as right click > save link as, so I will add it as an extra step above.

---re-edit
Also confirmed with a friend running brave 1.40(.113) on w10.

@fmarier
Copy link
Member

fmarier commented Jul 6, 2022

You're right, I had that option enabled and without it I can reproduce the problem you described.

Prior to 1.40 it was downloading the CRX file instead of trying to install it?

@pitsi
Copy link
Author

pitsi commented Jul 6, 2022

Yes. It is not trying to install it, because the installation was and is (and will always be) manual.
It is not downloading it or deletes it once it finishes downloading.

@rebron rebron moved this from Untriaged Backlog to P4 Backlog in General Jul 19, 2022
@rebron rebron moved this from P4 Backlog to P5 Backlog in General Jul 19, 2022
@rebron rebron added priority/P5 Not scheduled. Don't anticipate work on this any time soon. and removed priority/P4 Planned work. We expect to get to it "soon". labels Jul 19, 2022
@pitsi
Copy link
Author

pitsi commented Sep 28, 2022

Three months and four major updates later (for both brave and chromium) and the issue is still there.
Can we finally say this is an upstream "feature" of chromium since v103 and call it a day?
I really have no problem using the workaround that was described above.

@fmarier fmarier added the Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix label Oct 14, 2022
@fmarier
Copy link
Member

fmarier commented Oct 14, 2022

You're right, it's an upstream issue and we would likely want to see it fixed there instead of carrying an extra patch.

@pitsi
Copy link
Author

pitsi commented Oct 15, 2022

Has anyone filed an issue report for it upstream?

@pitsi
Copy link
Author

pitsi commented Jan 25, 2023

Did someone reply on this and deleted his message? I got a notification, but there was nothing here when I checked.

@Oppen
Copy link

Oppen commented Jan 25, 2023

Yes, I commented but then I realized what I said was incorrect and didn't want to bother.

@pitsi
Copy link
Author

pitsi commented Jan 26, 2023

Ok no worries :)
I thought someone found another workaroud to the issue and I wanted to check it out.
As it seems, this is now a "feature" of chromium and it won't be fixed in the future.

@ghost
Copy link

ghost commented Feb 22, 2023

I have same problem, CRX_REQUIRED_PROOF_MISSING error on clicking a link which contains the download file for .crx extension. I can see this is not occuring on Linux.

OS: macOS(Apple Macbook Pro)
Version: 1.50.53 Chromium: 110.0.5481.104 (Official Build) nightly (x86_64)

Also, cannot enable an extension after dragging and dropping even when developer mode is turned on.
The Extension shows error This extension is not listed in the Brave Web Store and may have been added without your knowledge. Since Chrome is now not allowing to install extensions which are outside of Chrome web store, I think there is a need to fix this and may no longer be an upstream issue.

image

I wrote a reddit post about it on r/brave_browser

@fmarier
Copy link
Member

fmarier commented Feb 22, 2023

@dpthegrey It might be better to file a separate issue for the behavior you are seeing.

The present issue is around the inability to download a CRX file unless one enables the setting mentioned in #23680 (comment). It sounds like the problem you have is that you already have the CRX file, but you cannot side-load it.

@ghost
Copy link

ghost commented Feb 22, 2023

@fmarier my apologies for mixing up side-loading issue along with failing to download CRX file with an error CRX_REQUIRED_PROOF_MISSING browser error.

I can confirm about not being able to download CRX file through a link containing CRX file directly, without Save Link As... option on right click over the link.

@pitsi
Copy link
Author

pitsi commented Nov 2, 2023

It has been more than one year and exactly 20 releases of brave (counting today's 1.60.x) since this and as it seems nothing is going to change. Can we call it a feature of chromium, close this and call it a day?

@fmarier
Copy link
Member

fmarier commented Nov 2, 2023

Can we call it a feature of chromium, close this and call it a day?

Given that there is a work-around and that it's not looking like that behavior will change in Chromium, I think we can close it.

@fmarier fmarier closed this as completed Nov 2, 2023
General automation moved this from P5 Backlog / waiting upstream to Completed Nov 2, 2023
@rebron rebron removed this from Completed in General Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix closed/wontfix feature/extensions OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. workaround-available
Projects
None yet
Development

No branches or pull requests

4 participants