New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding notch / band stop filter to raw.filter #98
Comments
AFAIK nobody is working on this just be careful that filters you use are zero-phase |
Another option is to adapt the line filtering routines from Chronux, as they don't require the use of band-stop filters. |
heard this one before on the mailing list (probably you mentioned it:) On 24.10.2012, at 23:54, Eric89GXL notifications@github.com wrote:
|
Basically it uses multi-taper estimation combined with an F statistic to infer if there were significant sinusoidal components in the data. You can even specifically tell it which frequencies to test, which is nice because you could restrict it to the line freq and its harmonics. I haven't personally tried it on M/EEG data, though... |
sounds cool. On 25.10.2012, at 00:07, Eric89GXL notifications@github.com wrote:
|
woops, sorry, something was missing-- would be good to have one or two references from meeg studies using this technique. but anyways, sounds very nice. D On 25.10.2012, at 00:14, "Denis A. Engemann" denis.engemann@gmail.com wrote:
|
Just a reminder to @agramfort to look into notch filtering for 0.6, as our code could easily knock out a small band of frequencies. |
also see #98 On 10.12.2012, at 20:48, Eric89GXL notifications@github.com wrote:
|
@agramfort do you have input on this? I assume you haven't had a chance to look through other packages... Since I can't work on #11 while traveling, I might try to work on a few options for this: an FIR/FFT band-stop, an IIR band-stop, and I'll try doing what is done in chronux (although I've read through some of that code before, and it's not the easiest thing to understand). Let me know if you have other methods ideas. |
indeed no time to look carefully. I would fly with the code of the standard |
We are using a perl translation of this matlab window-sinc filter, http://www.gomatlab.de/window-sinc-filter-t19156.html I always wanted to translate it, but always other stuff seemed more On Fri, Dec 21, 2012 at 9:55 AM, Alexandre Gramfort <
|
Closing this to move discussion to #316. |
Is anyone intending to work on this in the nearer future?
My take would be to look to go through the examples from the recent mailing list discussion and see what fits best / is most worth being implemented. Another option not mentioned so far could be:
http://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.cheb1ord.html#scipy.signal.cheb1ord
and cheb2ord, ellipord
The text was updated successfully, but these errors were encountered: